Shawn Walker wrote:
Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-8318-v1/

Bug:
8318 search v1 not sending uuid
http://defect.opensolaris.org/bz/show_bug.cgi?id=8318

Short webrev that makes the logic simpler and correct. No test case was added since the id isn't shown in the depot logs to my knowledge, but is shown in the apache logs. I hand tested it by searching against ipkg and watching the logs there. If anyone has an idea of how to test this in the test suite (in a reasonable manner given the time constraints we're under), please let me know and I'll add it, otherwise I'll file a bug for it.

It is quite easy to test for headers.  Look at tests/cli/t_pkg_intent.py.

I added something to the depot just for this case :)

Cheers,
Thanks for pointing that out :)

New webrev up @ http://cr.opensolaris.org/~bpytlik/ips-8318-v2/
Now with test cases!

Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to