Greetings,

The following webrev contains fixes for the following issues:

  8321 image_create should not validate publisher uri
  8361 usage and error methods could be consoldiated
8362 image.set_attrs failure due to invalid publisher info leaves empty image

webrev:
http://cr.opensolaris.org/~swalker/pkg-8321/

Change Summary:
* Fixed pkg to properly display image-create errors with subcommand prefix (e.g. pkg: image-create:)

* Fixed pkg image-create to allow image.set_attrs() to perform publisher URI validation so that more informative error message is printed for failure (e.g. something like "'%s' is not a valid publisher URI" instead of "invalid publisher URI")

* Consoliated cmd_error, error and cmd_usage, usage methods in pkg

* Fixed bug where image.set_attrs() could create an empty, useless image if publisher object creation failed due to invalid chars in publisher prefix or other invalid information (such as a bad publisher origin URI)

* Added unit test to verify empty image won't be created if image-create fails due to invalid information

Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to