Shawn Walker wrote:
jmr wrote:
Perhaps the best place to fix this is in image.py where any public methods such as load_catalogs that might not be thread safe should be protected with an acquire and release lock as is done in all the api.py public methods. I'm happy for us to fix it in PM for now, but could you log an enhancement request for image.py.

Methods in image.py are not intended for use by the client which is the real issue that needs to be addressed.
Ah OK I thought as they did not have the __ in image.py it was ok to use them, but if not then fine. I agree that having them in the api.py is the way to go with the appropriate locking code in place to protect clients. For this rev we will protect the calls in PM and for next rev move over to using an appropriate API in api.py.

JR

If the api was being used here, it would handle the locking aspects automatically.

Cheers,

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to