hey dan, this looks good. i have a few general comments/questions. - in common.ksh, when you run "pkg list" you set LC_ALL=C, but you don't do this in other places when you run "pkg list"?
- seems like there should be an RFE for "pkg list -o XXX"? - should there be an option to install so that it looks at datestamps when updating packages? (so you don't need the hack in attach.) - can package names have spaces in them? if not, then this comment doesn't really matter as much. but i noticed that running "pkg list -H" behaves a little too much like a normal "pkg list". the "pkg list -H" output is exactly the same as without '-H', just sans the header line. compare this to the zfs commands. if you don't specify '-H' with zfs list, then it outputs a header line and all the columns are width adjusted to align propertly, using spaces for padding. but if you do specify '-H', then not only is the header line dropped, but the column seperator changes from multiple spaces to a single tab. this is critical for scripting because filesystem names can have spaces in them, so the use of tabs as seperators allows scripts to propertly parse the output. ed On Wed, Apr 29, 2009 at 02:05:59AM -0700, Dan Price wrote: > > I have fixes for the following issues: > > 7490 ipkg brand attach needs similar logic to pkgcreatezone for 'entire' > incorporation > 8500 ipkg brand should mimic live cd, not create search index until user > asks for it > 8501 Chaff on the screen in zone install due to image-create's refresh > progress display > > Review is at: > > http://cr.opensolaris.org/~dp/pkg-zonefixes2/ > > I realize that the output can be a bit hard to imagine, so here is > an example: > > # zoneadm -z foo attach -u > Global zone version: [email protected],5.11-0.111:20090418T200225Z > Non-Global zone version: [email protected],5.11-0.111:20090331T092149Z > Publisher Check: Zone preferred publisher does not contain > [email protected],5.11-0.111:20090418T200225Z. > Publisher Reset: Copying preferred publisher from global zone. > Cache: Using /var/pkg/download. > Updating non-global zone: (Stage 1). Output follows > Removal Phase ... Done > Install Phase ... Done > Update Phase ... Done > Updating non-global zone: (Stage 2). Output follows > Download: SUNWPython ... Done > Download: SUNWTcl ... Done > ... <snip> ... > Download: SUNWzone ... Done > Install Phase ... Done > Update Phase ... Done > Updating non-global zone: Zone updated to > [email protected],5.11-0.111:20090418T20 > 0225Z > Attach complete. > > > Due to a minor issue in BrandZ, stdout for the "attach" brand hook > is not-a-tty, so we wind up with the less attractive progress tracker. This > is fixed in snv_113 I believe (thanks to Jerry), and so things will look > better down the road. > > Working on these fixes (and reviewing Ed's impressive fix for 7491) > have made me a lot more certain that I should be rewriting the bulk of > this in python. > > Thanks, > > -dp > > -- > Daniel Price, Solaris Kernel Engineering http://blogs.sun.com/dp _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
