On Thu, Apr 30, 2009 at 01:25:35PM -0700, Dan Price wrote: > On Thu 30 Apr 2009 at 12:54PM, [email protected] wrote: > > Folks, > > Dan / Bart recently found a bug where POST requests that are larger than > > 128k fail in some situations. I've made a small change to the filelist > > code that limits the number of files per download, thereby limiting the > > maximum size of the POST request. This allows a FileList request that > > contains many small files to succeed when the client is downloading > > from a server with this kind of limit. The change is pretty small, and > > the webrev is listed below. > > > > http://cr.opensolaris.org/~johansen/webrev-8538/ > > This looks good to me. Thanks for investigating. I also like that > you got rid of the -b.
Thanks to you and Danekbot for the review. The -b option seemed pretty silly if the client were to have both size of files and number of files figure into the FileList sizing equation. Since -b was undocumented, and AFACIT unused, it seemed pretty obvious to remove it. When we first designed FileList, we thought it might be useful to have these values be tuneable, but I haven't seen any need for this so far. That made me think it was safe to remove this altogether. Thanks again, -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
