Yep - look good.

Have you checked for any other instances for self.w_dialog.hide()? Looks like we handle everything else in the generic error handler [__g_error_stage()] whose gui interaction elements are correctly wrapped, but just want to check.

JR


Padraig O'Briain wrote:
Looks good to me.

Padraig

Michal Pryc wrote:
Hello,

The webrev:
http://cr.opensolaris.org/~migi/gate_8645/

It's only 1 line change:

http://cr.opensolaris.org/~migi/gate_8645/src/gui/modules/installupdate.py.wdiff.html

Fixes bug:
http://defect.opensolaris.org/bz/show_bug.cgi?id=8645

The problem was that gtk call was done from not gtk thread.

best
Michal Pryc

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to