Hi,
It looks and works fine for me. I did check with different scenarios,
when one/few repositories were disabled and rest was eiter enabled
either not added. The Webinstall in all situations behaved correctly.
Michal
Padraig O'Briain wrote:
Looks good to me.
Padraig
jmr wrote:
Thanks for the catch Padraig, was caught in mid thought. Tested with
several disabled repos and working fine.
New webrev:
http://cr.opensolaris.org/~jmr/pm_8593_webinstall_disabled_repo_5May_2pm/
JR
Padraig O'Briain wrote:
I think that there is something wrong with self.pub_disabled.
Can you describe what this variable is for?
If there are two publishers, the first of which is disabled,
self.pub_disabled will be true the second time we come to line 254.
Padraig
On 05/05/09 11:23, jmr wrote:
Hi,
Fix to warn user when they are trying to do a webinstall against
disabled repositories. We need to check if a repo that is not
registered is also disabled, otherwise the user gets a pretty
confusing message when they hit Proceed, about having duplicate repos.
http://cr.opensolaris.org/~jmr/pm_8593_webinstall_disabled_repos_5May_1105am/
8593 Webinstall against disabled repositories gives poor error message
JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss