On Thu 30 Apr 2009 at 05:32PM, Edward Pilatowicz wrote:
> hey all,
>
> after further testing i discovered a serious bug in my code around
> snapshot renaming. specifically, you can't rename snapshots that have
> clones which are zoned or in use. (and all clones created by beadm or
> zone cloning have the zoned attribute set.) oops.
>
> i've added a new block of logic to the main processing loop to deal with
> this. the unplesant bit is that we need to clear the zoned attr on
> clones before renaming snapshots and then restore it afterwards. i've
> also added logic to detect configurations where renames are going to
> fail so that we can present the user with an informative error message
> and abort (instead of just hitting a rename error after we've start
> modifying filesystems.)
>
> i'm planning to file another zfs rfe for a mechanism to allow the global
> zone to override the "zoned" attribute when doing operations. (since
> that would help simplify some of this logic.)
To conclude this: I've looked this over, and will commit it for Ed.
Ed-- Many thanks. This was a big and intricate effort.
-dp
--
Daniel Price, Solaris Kernel Engineering http://blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
