Tom Mueller wrote:
The new version of api.py only reads the pkg.summary from the
package. This means that old packages that only have a "description"
attribute won't have anything printed. The bug report requests reading
the description if the pkg.summary is not there.
Good point. Okay, here's a new webrev that fixes that:
http://cr.opensolaris.org/~richb/pkg-4395-8829-v3
Thanks.
Rich Burridge wrote:
Hi all,
(This is for after OpenSolaris 2009.06).
Thanks for feedback from Danek and Tom. I think I have a clearer
understanding of what is required here now.
Here's a second webrev. I've combined the patches for 4395 and 8829
as they are so tightly connected.
http://cr.opensolaris.org/~richb/pkg-4395-8829-v2/
Changes made:
* solaris.py now publishs "add name pkg.summary ..." lines in
the package manifest.
* .../modules/client/api.py now gets "pkg.summary" entries from
the package manifest for the "pkg info" Summary: line.
* In solaris.py, if there was no "summary" line in the IPS package
definition, the summary is now derived from the SVR4 package's
pkginfo file's NAME line.
* In solaris.py, if there was no "description" line in the IPS package
definition, the description is now derived from the SVR4 package's
pkginfo file's DESC line.
* All the IPS package definition files that previously had
"description" lines have been adjusted to now have "summary" lines.
This has made the patch a tad bigger.
There is a local (internal) repository with a "redist_import"
published to it at:
http://stard.sfbay.sun.com:24395
Discussion point:
* With the above changes, Danek suggested we could also add a "-v"
sub-command line option to "pkg info" that would also print out
the package description.
I was going to just make the changes in with this webrev, but then
I realized that "pkg info" currently doesn't have a "-v" sub-option,
so as it's also going to affect the usage message, man pages etc.,
it's probably best to just fill out a new RFE on this, if folks
think it's a good idea.
Thanks.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
