On Thu, May 28, 2009 at 4:33 AM, Shawn Walker <[email protected]> wrote:
> [for post 2009.06?]
>
> Greetings,
>
> The following webrev contains fixes for the following issues:
>
> 9194 repositoryconfig validation raise_error ignored for ATTR_TYPE_URI_LIST
>
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-9194/
>
> Cheers,
> --
> Shawn Walker
So far looks good to me.
Only one question:
In ...
@@ -381,10 +381,16 @@
rc = rcfg.RepositoryConfig()
# Verify that False is returned for an invalid attribute value.
self.assertFalse(rc.is_valid_attribute_value("feed", "id",
"8baf-433b-82eb-8c7fada847da"))
+ # Verify that an exception is raised when raise_error=True for
+ # an invalid attribute value.
+ self.assertRaises(rcfg.InvalidAttributeValueError,
+ rc.is_valid_attribute_value, "feed", "id",
+ "8baf-433b-82eb-8c7fada847da", raise_error=True)
+
# Verify that True is returned for a valid attribute value.
self.assertTrue(rc.is_valid_attribute_value("feed", "id",
"16fd2706-8baf-433b-82eb-8c7fada847da"))
def test_is_valid_attribute_value_bool(self):
... is it the intended behavior that you return the same id
"8baf-433b-82eb-8c7fada847da", rather than a new unique one?
Martin
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
