Too many bugs.
It was bug #4470 that Shawn wanted me to do a test case for.
That's now done. See:
http://cr.opensolaris.org/~richb/pkg-4470-v2/
Looking for two code reviewers for this one.
----
For the other one (bug #4542), I need one more reviewer.
4542 malformed group file causes client traceback
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=4542
Last message:
http://mail.opensolaris.org/pipermail/pkg-discuss/2009-April/013188.html
Last webrev: http://cr.opensolaris.org/~richb/pkg-4542-v1/
I have one +1 from Danek so far.
-------- Original Message --------
Subject: Re: [pkg-discuss] Code review: bug #4470 - passwd/group
"compat" entries cause stack trace
Date: Tue, 02 Jun 2009 17:37:45 -0500
From: Shawn Walker <[email protected]>
To: Rich Burridge <[email protected]>
CC: pkg discuss <[email protected]>
References: <[email protected]> <[email protected]>
<[email protected]>
Rich Burridge wrote:
Shawn Walker wrote:
Rich Burridge wrote:
Hi all,
(This is for after OpenSolaris 2009.06).
Looking for a code review of the proposed fix for bug #4470:
http://defect.opensolaris.org/bz/show_bug.cgi?id=4470
passwd/group "compat" entries cause stack trace
Webrev is at:
http://cr.opensolaris.org/~richb/pkg-4470-v1/
Note that the indentation in this file is 4 spaces rather than 8
before we go down that rathole.
Hi Rich, this looks like it would work, but can you add a unit test?
I certainly could, but that will take me quite a bit longer as
I'm not a pkg test case master yet.
I think it's worth it, since we want to be certain this doesn't break again.
You can add your test to api/t_unix_usergrp.py which should make it easy.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
