Looks good, tested the changes with a p5i file without a .p5i extension and a corrupted p5i, change behaves as expected. Interestingly giving the Close button focus is not required, hitting return will close the dialog, so its defaulting to the Close action anyway, but no harm making it explicit.

JR

Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-8966-v2/, fixes
8966 PM should be able to handle p5i data from a webserver without a .p5i extension

This change removes the requirement that a p5i file have .p5i extension.
It also makes minor changes to the error handling:

1) When the message "All specified repositories and packages are already on the system." is displayed the Close button has focus. 2) When an error occurs parsing the p5i file the program terminates after the user has acknowledged the error message.

Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to