On Thu, Jun 11, 2009 at 04:21:11PM -0700, Dan Price wrote:
> http://cr.opensolaris.org/~dp/pkg-bldentire/
Just a few nits:
- You do an "|| exit 1" in a bunch of places, but on lines 57 and 61, you
do an explicit test of $?. You can probably just do the former in both
those places.
- On line 75, you have a space between -u and its argument, unlike on
lines 42 and 46; I tend to leave out the space here.
> On thing I noticed along the way was that the only metadata we decorate
> onto 'entire' is a description. I could add more. Is there anything
> else we would want on it?
I don't think so. A classification seems like overkill. The description
could be a bit better, IMHO, but it's a bit difficult to explain what
entire actually does in a short amount of space. However, you could change
"description" to "pkg.summary", which it looks like we missed with the rest
of Rich's change.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
