Ed,
Edward Pilatowicz wrote:
comments for the p2v script are below.
ed
----------
src/brand/p2v
- in general, you only need to specify full paths to binaries if
you haven't explicitly set PATH. since you've set PATH, you
don't really need full paths to any binaries. (except of course
ones run via zlogin.)
I'll remove the absolute paths.
- the usage() messages has a "patchid" parameter?
Oops, that was leftover from the ON code. I'll remove it.
- fix_net() checks STACK_TYPE, but it seems that STACK_TYPE doesn't
get set until after fix_net() is called.
Another oops. I had moved some stuff around and missed this,
thanks for catching it.
- you check for the presence of /etc/hostname.* files, but you don't
check for /etc/dhcp.* files?
I'll add that.
- why are you creating tmp files in /var/tmp instead of /tmp?
Thats the same code the ON p2v is using. I'm not sure the origin
of this, it might date back to etude where we wanted to keep some
tmp files around over reboots for debugging, but I'm not sure.
In this case I don't see any good reason for that so I'll change it.
- in p2v you do "umount $ZONEROOT", but if the zone had any "fs"
resourced defined it's zonecfg, then those filesystems will be
mounted under $ZONEROOT, and so this operation will fail.
I'll change that to use the umnt_fs function.
- fix_smf_pre_uoa() is a huge function that doesn't seem to
be called from anywhere?
Thats a mismerge, thanks for catching it.
- in multiple places you zlogin and run svcs. you might want to set
LC_ALL=C before running svcs.
Will do.
- when running svcs you always pipe the output to nawk. why not just
use the -o option?
Not always, but I'll fix the appropriate places.
- the comment when you run sys-unconfig says you wait for 30 seconds,
but the code loops up to 10 times and does a "sleep 10" each time.
I'll fix the comment.
Thanks again for reviewing this, I'll post an updated webrev for all
of the changes later this week.
Jerry
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
