Padraig looks good to me, one minor nit, should put this duplicated code into a separate func:

     404 +                        self.last_check_time = time.time()
405 + # Add random delay so that servers will not be hit 406 + # all at once
     407 +                        random_delay = random.randint(0, 1800)
     408 +                        if debug:
     409 +                                print "random_delay in 
do_next_check", random_delay
     410 +                        gobject.timeout_add(random_delay * 1000, 
self.check_for_updates)

JR


Padraig O'Briain wrote:

I have respun the webrev, http://cr.opensolaris.org/~padraig/ips-9401-v1/, to put a random delay in updatemanagernotifier.py.

Padraig


On 06/11/09 10:59, jmr wrote:
Looks good - we also need similar functionality in updatemanagernotifier.py.

JR

Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-9401-v1/, fixes
9401 UMN should introduce a dither for update time checks to spread server load

Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to