On Jun 23, 2009, at 12:22 PM, Padraig O'Briain wrote:
Shawn Walker wrote:
On Jun 23, 2009, at 9:16 AM, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-9501-v1/, fixes
9501 packagemanager traceback on memoryerror
The fix is to do catching memory errors when installing or
removing in the same way as the cli.
Are you sure this shouldn't be a general top-level exception case
in packagemanager.py instead of just for the installupdate case?
Of course I don't know if you can do that.
You might want to do this for updatemanager as well (another bug?)...
This change will work for updatemanager also if the memory error
occurs during update.
I need to think about whether we can do something in
packagemanager.py. Even if we do, I think that this webrev should be
applied.
If you had the general top-level handler in packagemanager.py you
probably wouldnt need one in installupdate.py, but maybe you do. I'm
not quite certain how you have to handle exceptions so you can do
things gracefully in the GUI.
If that's the case, this is probably fine to apply.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
