On Wed, Jun 24, 2009 at 04:54:13PM +0100, Peter Dennis - Sustaining Engineer wrote:
> There are a couple of calls within the pspawn() function which simply > call the PyErr_NoMemory() function without capturing or returning the > value from the call but instead later returning a NULL. Should those be fixed as part of this wad, or is there a separate bug open against them? > The PyErr_NoMemory() always returns a NULL (as stated by the Python > docs), so it would appear that both conventions are okay but which > is better ? <shrug> > I do prefer the explicit return of NULL, however I am more than > happy to bow to greater knowledge. I don't care too much here; it's clear to me either way what's going on. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
