Rich Burridge wrote:
Brock Pytlik wrote:
New webrev at:
http://cr.opensolaris.org/~richb/pkg-9485-v2/
pkgplan.py:
I'm pretty sure that line 170 should be indented 4 spaces, or I'd
like other formatting changes to be made as this was hard to read for
me.
Lines 169 and 170 are both continuation lines of line 168.
I indented them four spaces as this is similar to the way that
it's done for lines 159-161 in the same file.
Ok, I think this formatting convention is especially confusing this
context, but I agree that we should at least keep the file consistent.
In general, I wish we'd adopt a new indent level for each nesting of
function calls, but from what I can tell, that ship's sailed.
Brock
Other than that LGTM
Thanks.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
