Thanks for the review Shawn, I agree with your comment below and will be
spinning a webrev which includes this change shortly.
JR
Shawn Walker wrote:
On Jun 25, 2009, at 6:04 AM, jmr wrote:
Hi , here is a webrev to move PM over to using the Search API for all
searches, both against single publishers (previously used GtkTreeView
filtering) and all publishers (added in 2009.06, already using Search
API).
webrev:
http://cr.opensolaris.org/~jmr/pm_8324_local_search_using_api_25Jun_1150am/
9442 Use Search API in PM for all searches
This will cause a slow down when searching against Single Publishers.
The timings for a search are listed in the Status Bar if it takes
longer than 1 sec. If a repo cannot be contacted there is a time out
of 30 secs, which is caught and reported as a failed search against
the repo. When we have better exceptions here from the transport
layer [9670] we can do a better job of handling the range of errors.
The only comment I have is that I think the package list needs to be
cleared in this scenario before search starts:
* user launches packagemanager
* clicks search box and enters text
* presses enter key starting search
* packagemanager switches to package listing already showing packages
^^^^ This is the part that is somewhat confusing because it might
mislead you into believing the search had finished already.
* packagemanager then clears listing and shows actual results
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
