Thanks Padraig, comments below, will send out webrev shortly:
JR
Padraig O'Briain wrote:
Some comments after reading through the code changes again:
packagemanager.py:
Line 241 could be removed
Done
Line 809 and 810:
I know these lines are not changed as part of this webrev but I do not
understand what purpose is served the _ on these two lines.
Removed
Line 1794:
Should the time required to get the package list corresponding to the
search results be counted as part of the search time? if it is
significant the user will think it should be.
Done
Line 3825 and following:
Should mapping keys be used in the format statements to allow for
reordering of variables in translation?
Done - this turned up some bugs in the elapsed time calculation when
errors occurred in Search All, sorted these as well.
Padraig
On 06/25/09 12:06, jmr wrote:
Another note is that we are fetching Descriptions on the fly for the
visible rows in this webrev, which can cause some redraw issues when
paging down quickly in the package list view.
JR
jmr wrote:
Hi , here is a webrev to move PM over to using the Search API for
all searches, both against single publishers (previously used
GtkTreeView filtering) and all publishers (added in 2009.06, already
using Search API).
webrev:
http://cr.opensolaris.org/~jmr/pm_8324_local_search_using_api_25Jun_1150am/
9442 Use Search API in PM for all searches
This will cause a slow down when searching against Single
Publishers. The timings for a search are listed in the Status Bar if
it takes longer than 1 sec. If a repo cannot be contacted there is a
time out of 30 secs, which is caught and reported as a failed search
against the repo. When we have better exceptions here from the
transport layer [9670] we can do a better job of handling the range
of errors.
JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
