Thank you for the review, Shawn. All comments have been addressed, and
a new webrev against the gate from today is posted here:
http://cr.opensolaris.org/~tmueller/ips-8194.2/
Tom
Shawn Walker wrote:
Tom Mueller (pkg-discuss) wrote:
Please review the changes for these issues:
6871 option to automatically set UUID for image publishers
8194 image configuration should be re-saved after load if possible
Webrev: http://cr.opensolaris.org/~tmueller/ips-8194/
These changes move the code that modifies the cfg_cache file when it
is read in into the imageconfig module. It also reorders how the data
is read so that if the file needs to be written out due to a change,
it doesn't have to be reread. It checks to see if the UUID for a
publisher is modified when the publisher is read in and saves the
cfg_cache file in that case. And finally, it makes the client_uuid
value in an Image always a string. It was a UUID or a string before,
depending on whether there was a value defined in the cfg_cache file.
src/modules/client/imageconfig.py:
lines 261-262: drop (extra newline)
src/tests/api/t_imageconfig.py:
line 123: Can you move the comments from lines 127-128 here and use
them as a docstring for the test instead? The advatange is that
docstrings for the test can be shown during test failure.
Also, can you re-merge with the gate and re-post? Several things have
changed in ImageConfig very recently that aren't reflected in your
webrev.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
