Works for me. Thank you. --joanie On Fri, 2009-07-10 at 15:23 +0100, jmr wrote: > Here's a new webrev that addresses the issues raised by Padraig and Joanie. > > webrev: > http://cr.opensolaris.org/~jmr/pm_filter_search_results_010Jul_315pm/ > 9944 PM allow filtering of Search Results > 9881 Clear and Clear Search no longer restore the full list of packages > > JR > > > > jmr wrote: > > Joanie - I hear you loud and clear. If a user is moving to another > > repo we don't know if they intend to search or browse, so it is a > > problem to set the focus back to search. In the example below if you > > hit space to expand the combobox you can get around the issue you > > describe, but that's not the point. > > > > So I will change this: > > - When switching repos do not reset the focus back to the Search field. > > - However, when you switch to Search All Repos then it makes sense to > > set the focus in Search as there is nothing else the user can do in > > this mode, they can only search, so this covers at least part of my > > use case: searching in one repo, not finding it, switching to All > > repos and then search again. > > > > JR > > > > Joanmarie Diggs wrote: > >> Hi John, all. > >> > >> On Fri, 2009-07-10 at 10:33 +0100, jmr wrote: > >> > >>> Yep - the usage scenario is: I am looking for something in foobar > >>> pub, don't find it then switch to zoobar pub and search for it > >>> there. This behavior makes that very easy to accomplish. > >>> > >> > >> Consider this usage scenario: I am searching for something in foobar > >> pub, don't find it, move focus to the Repository combo box for the > >> purpose of switching to the zoobar pub and press Down Arrow: > >> Unfortunately, my pub list is: > >> > >> * foobar > >> * boobar > >> * zoobar > >> > >> The act of pressing Down Arrow for the purpose of ultimately selecting > >> the zoobar pub triggers focus to be moved back to the search entry. Now, > >> because of your programmatic focus change, I must move focus back to the > >> Repository combo box before I can Down Arrow again to the zoobar pub. > >> > >> I personally do not think it is safe to assume that you can reliably > >> surmise the user's intent based simply upon the fact that the selected > >> item changed in a widget after a search had been executed. To then move > >> focus to another widget based upon that potentially erroneous conclusion > >> strikes me as a bad idea. > >> > >> FWIW. > >> --joanie > >> > >> > >>> JR > >>> > >>> > >>> Padraig O'Briain wrote: > >>> > >>>> When I switch repository after doing a local search the text stays > >>>> in the search field. > >>>> Is this the intended behavior? > >>>> > >>>> Padraig > >>>> > >>>> On 07/10/09 08:13, Padraig O'Briain wrote: > >>>> > >>>>> I have no strong views about the change of behavior, but I see > >>>>> that Jenya is happy with it which is good enough for me. > >>>>> > >>>>> It is good to see a code change which reduces the size of the code. > >>>>> > >>>>> I think that you can remove __link_load_blank as it is no longer > >>>>> used; also the commented out line 1871. > >>>>> > >>>>> One thing you might take from my original webrev for 9881 is to > >>>>> use self.w_searchentry.get_text_length() consistently instead of > >>>>> len(self.w_searchentry.get_text()) or > >>>>> self.w_searchentry.get_text() == "" > >>>>> > >>>>> Padraig > >>>>> > >>>>> On 07/09/09 21:30, jmr wrote: > >>>>> > >>>>>> Hi, this webrev allows filtering of search results using the Show > >>>>>> filter for Installed, Not Installed and so on. > >>>>>> > >>>>>> When you go into search now, we do not switch to All Packages. > >>>>>> The Show filter applies to whatever you are looking at. > >>>>>> > >>>>>> I have changed how we go into Search All to be more consistent > >>>>>> with Single Search. I have also altered Clear, so now if you > >>>>>> backspace in the Search field to empty it nothing happens to the > >>>>>> displayed list, if you hit Clear it will clear the text field and > >>>>>> the list only if its displaying results. I know this overlaps > >>>>>> with a webrev you have out Padraig for 9881, but think with the > >>>>>> other changes its better to clear the result set and allow the > >>>>>> user to search again without putting them back into Browse mode. > >>>>>> > >>>>>> webrev: > >>>>>> http://cr.opensolaris.org/~jmr/pm_filter_search_results_09Jul_810pm/ > >>>>>> 9944 PM allow filtering of Search Results > >>>>>> 9881 Clear and Clear Search no longer restore the full list of > >>>>>> packages > >>>>>> > >>>>>> JR > >>>>>> _______________________________________________ > >>>>>> pkg-discuss mailing list > >>>>>> [email protected] > >>>>>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > >>>>>> > >>>>> _______________________________________________ > >>>>> pkg-discuss mailing list > >>>>> [email protected] > >>>>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > >>>>> > >>> _______________________________________________ > >>> pkg-discuss mailing list > >>> [email protected] > >>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > >>> > >> > >> > > > > _______________________________________________ > > pkg-discuss mailing list > > [email protected] > > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >
_______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
