Padraig,
checkforupdates:
few functions could be private
what happens if two separate processes tries to dump the cache?
what happens if the cache is corrupted ? (simply vi cache_file and
type someting to reproduce this)
cache.py:
import time (it's not needed anymore)
the rest LGTM
Michal
Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-9852-v2/ , fixes
9852 UMN and PM check for updates should use plan_update_all
This webrev does a number of things:
1) Rename um-checkforupdates to pm-checkforupdates and move from
SUNWipkg-um to SUNWipkg-gui.
2) Change packagemanager.py so that it calls pm-checkforupdates to
determine whether Update All button should be enabled.
3) Change checkforupdates.py to use plan_update_all to determine
whether updates are available.
Note that this is quite slow. It takes over 60 seconds on my system.
Following Shawn's suggestion we cache the last_refresh properties of
the publishers in the image and avoid running plan_update_all if they
have not changed.
When pm-checkforupdates is run by updatemanagernotifier it runs as the
logged in user and cannot write to the cache directory.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
