The --binary option makes it so that a patch that has lines that are not terminated by CRNL can be applied. Without the --binary option, GNU patch on Windows reports various different assertion failures. I also stumbled across saving the patch files with CRNL at the end of each line and that works too, but I don't think we want to save two versions of the patches or edit them on the fly.

Tom

[email protected] wrote:
On Mon, Jul 13, 2009 at 03:56:54PM -0500, Tom Mueller (pkg-discuss) wrote:
The webrev is here:
http://cr.opensolaris.org/~tmueller/ips-winbuild/

Why is it necessary to specify --binary as an argument to patch in the
Windows build?  This seems like it would prevent patch from applying
more clever algorithms for matching up lines that are slightly off.

-j


begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[email protected]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to