Looks good to me.
Padraig
On 07/13/09 18:02, jmr wrote:
Thanks Padraig,
webrev:
http://cr.opensolaris.org/~jmr/pm_816_search_compeltion_13Jul_545pm/
816 Provide Search Text completion
[Dup of 816: 9965 PM add search entry text completion]
JR
Padraig O'Briain wrote:
Some comments:
Line 344, 354 of cache.py:
Should you be using os.path.join to build up the file name?
I had logged 9512 about this in other code in cache.py.
Ok fixed for all occurrences in cache.py.
I am concerned about the naming of the file. I had a similar concern
when I was preparing webrev for 9852. It will not be pretty if
someone calls a repository search_completion.
Introduced some changes here to reduce likelihood of collision.
The changes to api.py are not related to this bug.
Removed.
Line 379 of packagemanager.py:
self.search_completion = gtk.ListStore(str)
Is this correct?
Yes this is correct and indicates that I want a string ListStore
Lines 3895 and 3905 completion mispelt in function name.
Ok
Please run pylint on the files you changed.
Done
Padraig
On 07/13/09 14:18, jmr wrote:
Respin against latest gate:
webrev:
http://cr.opensolaris.org/~jmr/pm_816_search_completion_13Jul_215pm/
JR
jmr wrote:
Update to the webrev to allow the search completion entries to be
persisted between invocations of PM. Number allowed is controlled
by a gconf key. We might want to allow a user to adjust this
setting and/or clear the list, but that will be handled in a
separate RFE.
webrev:
http://cr.opensolaris.org/~jmr/pm_816_search_compeltion_13Jul_140pm/
816 Provide Search Text completion
[Dup of 816: 9965 PM add search entry text completion]
JR
jmr wrote:
Hi - this webrev adds simple text completion to the Search entry
field. So type in something hit return and the entry is stored in
an in memory completion list. Next time you type if what you type
matches an entry in the completion list it pops up below the entry
and you can select it if you wish. Matching is simple case
insensitive string match.
The webrev does not persist the list of entries between restarts
of PM because one generally does not want to keep searching for
the same thing over and over again, unless of course you do a lot
of testing.
Jenya if you would prefer to have us persist the completion list
between invocations just let us know.
webrev:
http://cr.opensolaris.org/~jmr/pm_9965_search_compeltion_10Jul_5pm/
9965 PM add search entry text completion
JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
