Brock Pytlik wrote:
New webrev:
http://cr.opensolaris.org/~bpytlik/ips-9290-v4/

I've added a new bug into this change, 9908, which moves variant.py out of the client specific code so that it can be used by manifest, actions, and the publishing code.

modules/client/image.py:
  line 54: this should swap places with line 53

modules/client/imageplan.py:
  line 37: move this to just after line 32

modules/publish/dependencies.py:
  line 33-41: asciibetise these please :)

cli/t_pkgdep.py:
Missing test cases for '-i', '-m', '--help' and '-?'; it has '-I' and '-M' though.

Overall, I like this webrev a lot better than the last! The organisation seems really clean now.

Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to