On Thu 16 Jul 2009 at 06:31PM, Edward Pilatowicz wrote:
> i've updated the webrev with your feedback.
> my replies are inline below.
Ed, thanks for this effort. Very impressive.
How will this code handle packages published without any variant
info? Are there test cases for that?
client.py:600:
name, value = (arg.split('=', 1)[0], arg.split('=', 1)[1]);
Given the guard above it, I think this can be written:
name, value = arg.split('=')
client.py:(several places):
Why are you stripping out the inventory exception?
743 - error(_("install failed (inventory exception):\n%s") % e,
744 - cmd="install")
864 + error(_("install failed"))
I just don't know the logic for this change, and there is no associated
bugid.
In your test code, it would be nice if i_verify, p_verify, etc.
had some explanatory comments.
In i_verify
# XXX: is there a real interface to get variant settings?
I would suggest either:
- import and use imageconfig from our modules.
- import and use ConfigParser (from python)
Thanks,
-dp
--
Daniel Price, Solaris Kernel Engineering http://blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
