I have respun the webrev,  http://cr.opensolaris.org/~padraig/ips-10131-v2/

Padraig

On 07/21/09 11:33, Michal Pryc wrote:
Padraig,
I believe the lines:


3435 3436 share_path = "/usr/share/package-manager/data/"
3436 3437                  for pub in pubs:
3437 3438 category = imginfo.read(self.application_dir +
3438 3439                              share_path + pub)
3439 3440                          if len(category) == 0:
3440 3441 category = imginfo.read(self.application_dir + 3441 3442 share_path + "opensolaris.org")
3442 3443                          categories[pub] = category
3443 3444 section = sectioninfo.read(self.application_dir +
3444 3445                              share_path + pub + ".sections")
3445 3446                          if len(section) == 0:
3446 3447 section = sectioninfo.read(self.application_dir + 3447 3448 share_path + "opensolaris.org.sections")
3448 3449                          sections[pub] = section


Should also have os.path.join. The same applies to:

3842 3843          def get_icon_pixbuf_from_glade_dir(self, icon_name):
3843 3844 return gui_misc.get_pixbuf_from_path(self.application_dir +
3844 3845                      "/usr/share/package-manager/", icon_name)
3845 3846

best
Michal

Padraig O'Briain wrote:
The webrev,http://cr.opensolaris.org/~padraig/ips-10131-v1/, fixes
10131 check for updates can traceback if check for updates is missing

The change is to use PACKAGE_MANAGER_ROOT environment variable, if defined, to locate pm-checkforupdates.


Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to