OK. Looks good to me.
Padraig
On 07/23/09 16:14, Michal Pryc wrote:
Padraig,
It's the limit in the gui_pylintrc, which needs to be increased.
Changed in the:
http://cr.opensolaris.org/~migi/9363_update_all_user_image_v2
best
Michal
Padraig O'Briain wrote:
One nit: gui/modules/installupdate.py has a pylint warning
Padraig
On 07/23/09 13:35, Michal Pryc wrote:
The webrev is at:
http://cr.opensolaris.org/~migi/9363_update_all_user_image_v1/
There are two parts of fix:
- if the be name is entered in the BE name dialog, before performing
update all, then we are trying to create be. If this fails (most
likely it's user image), then we are re-doing the step, but this
time without passing be_name to the api, so it will proceed and
perform image-update. The lines 515-525 in the installupdate.py are
responsible for this step.
- If there is an user image, then we are passing flag to the
installupdate.py to hide the be naming dialog and proceed with
image-update.
Because PM and UM are using slightly different method to determine
the PKG_IMAGE, two different methods are in place to assume that
it's user image. We don't have api call to check if this is the user
image, so we need to guess this.
for the PM if the user set -R flag or PKG_IMAGE, we are assuming
that it is the user image
for the UM if the image is different then "/" we are assuming that
it is the user image
the bottom line is that if the PKG_IMAGE or -R is set to use non
existing image or "/" then it will default to "/" image. The be
naming dialog will be hidden, so it is not ideal, but it will work
fine, just with the default be_name provided by the libbe.
best
Michal
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
