On Wed 29 Jul 2009 at 10:16AM, Danek Duvall wrote:
> On Tue, Jul 28, 2009 at 05:43:47PM -0700, Dan Price wrote:
>
> > http://cr.opensolaris.org/~dp/pkg-logrotate/
>
> turn-logs.sh:
>
> - line 30: Maybe a parameter (though not an argument) to set the chunk
> size?
>
> - line 35: the /bin/sh invocation is wrong on Nevada; you might just want
> to have them chmod +x it and run it directly.
>
> - line 48: you don't actually need to declare the variable empty before
> using it.
>
> - line 56: don't need continuation character
>
> - line 57: you started this expression with "$(" and ended it with a
> backtick. That won't work. Pick one or the other (as long as it's
> "$()").
Sorry, that was some last second cleanup.
> - line 59: sure you still want this there?
Again...
Thanks, I've fixed up the rest, and will deploy this to ipkg
before putting back.
-dp
--
Daniel Price, Solaris Kernel Engineering http://blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
