On Fri, Jul 31, 2009 at 05:23:07PM -0500, Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-iso/
mkiso.sh:
- line 1: don't use -x here
- line 30: copyright date is not determined at runtime. Is a newline
supported in the ISO publisher field?
- line 33: Would a here-doc be simpler?
- line 33: Use $0? And do you need to spit the copyright here?
- line 70: usage should exit 2
- line 73, ff: Use [[ ]]
- line 93: Doesn't this mean that -h won't do anything? Also, strictly
speaking, a requested usage message should exit 0.
USAGE:
- line 17: worth talking about *how* that list of packages was determined?
- line 31: would it be worthwhile to say that you put the README from
this directory into <img_dir> at this point, too? Otherwise, line 36
seems a bit out of nowhere.
- line 61, 73: while using "[a-z]" won't hurt, technically it's only
"[a-f]". Or you could just use "?".
- I don't know if it's worth mentioning that the README file describes
how to put it all back together again. Perhaps that's obvious.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
