On Thu, Aug 20, 2009 at 11:53 AM, <[email protected]> wrote: > Folks, > The following is a small code review for 10808. This bug leads to pkg > statistics being printed twice. The __finished_execution function > copied the code that occurs below it, but failed to remove the code that > got copied. Thus, anytime PKG_DUMP_STATS is set, two copies of the > output gets printed. > > This change deletes the code that causes the second copy. > > ---- >8 cut here 8< ---- > > diff -r bbabec0772f0 -r c786cf7875ed src/modules/client/api.py > --- a/src/modules/client/api.py Thu Aug 20 09:15:06 2009 -0700 > +++ b/src/modules/client/api.py Thu Aug 20 11:49:22 2009 -0700 > @@ -654,16 +654,6 @@ > raise > > self.__finished_execution(be) > - > - > - > - try: > - if int(os.environ.get("PKG_DUMP_STATS", 0)) > > 0: > - self.__img.transport.stats.dump() > - except ValueError: > - # Don't generate stats if an invalid value > - # is supplied. > - pass > finally: > self.__activity_lock.release() > > ---- >8 cut here 8< ---- > > Thanks, > > -j
Looks good to me :) _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
