LGTM. i think that putting the files under b122 is the right thing todo. that way this changed will get implemented with the next build.
so with this putback (and with post snv_122 bits that have the fix for 4382889) can we successfully build onnv within a zone? ed On Fri, Aug 21, 2009 at 11:36:54AM -0700, Liane Praza wrote: > Please review my fix for: > 9887 osnet needs new dependencies for zones and upcoming flag days > http://defect.opensolaris.org/bz/show_bug.cgi?id=9887 > > I think the current convention is to put this under 122/common, but > correct me if I'm wrong. Other than that, the most interesting bit is the > diffs from 111a, which are included below. > > Full codereview at: > http://cr.opensolaris.org/~lianep/pkg-clone/ > > (I expect that since I was already made a leader and have done my 3 > commits that it's OK for me to commit directly after review is complete. > Please let me know if not.) > > liane > > $ diff -u 111a/common/osnet-dev 122/common/osnet-dev > --- 111a/common/osnet-dev Fri Aug 21 05:47:35 2009 > +++ 122/common/osnet-dev Fri Aug 21 07:55:53 2009 > @@ -6,26 +6,38 @@ > depend SUNWapch22 > depend SUNWastdev > depend SUNWbison > +depend SUNWbtool > +depend SUNWdbus > depend SUNWdtbas > depend SUNWflexlex > depend SUNWgcc > +depend SUNWgnome-base-libs > +depend SUNWgnome-vfs > depend SUNWgnu-gettext > depend SUNWhea > depend SUNWj6dev > depend SUNWjsnmp > +depend SUNWlibm > +depend SUNWmd > depend SUNWmercurial > depend SUNWmfrun > +depend SUNWnet-snmp-utils > depend SUNWonbld > +depend SUNWperl584usr > depend SUNWperl-xml-parser > +depend SUNWpkgcmds > depend SUNWpostgr-83-devel > depend SUNWpostgr-83-libs > depend SUNWprd > depend SUNWsfwhea > +depend SUNWsprot > +depend SUNWter > depend SUNWtlsd > depend SUNWtltk > -$(i386_ONLY)depend SUNWtss > +depend SUNWtss > depend SUNWwbapi > depend SUNWwbcou > depend SUNWwbdev > +depend SUNWwsr2 > depend SUNWxwrtl > end package > > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
