* Darren J Moffat <[email protected]> [2009-08-27 17:18]: > I'd like code/design review feedback for this minor pkg CLI RFE I've > just logged: > > I often start typing commands and forget what the exact usage is, so I > have a habit of tagging "--help" on at the very end so I get the usage > and then retrieved the command again via histroy and replace just the > last part of it (ie removing the --help). > > For example: > > $ pkg image-update --help > pkg image-updateh: illegal option -- help > Try `pkg --help or -?' for more information. > > $ pkg search -r --help > pkg search: illegal option -- help > Try `pkg --help or -?' for more information. > > What I wanted there was the full usage message not he short one. > I'd expect to get that short message if I gave an invalid option. > "--help" is valid but only directly after pkg and before the subcommand. > I find this too restrictive and would preffer the more flexible behaviour. > > Webrev: http://cr.opensolaris.org/~darrenm/pkg/
The client.py change seems reasonable, although I would probably be overprecise and introduce a new exception for a "UsageRequest". Maybe others care less? For the other fix, that looks fine, too. Thanks for catching the awk(1)/nawk(1) inconsistency. - Stephen -- [email protected] http://blogs.sun.com/sch/ _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
