Please review this change for fixing a problem with using the timestamp
tag on read-only files on Windows, which fails when utime is called on
read-only files.
Webrev: http://cr.opensolaris.org/~tmueller/ips-10629/
Bug: 10629 timestamp cannot be set on read-only file (Windows)
A couple of comments about this fix:
1. I debated implementing this by adding a portable.utime method, and
then implementing the error check and workaround in only os_windows.py.
However, os.utime is only called twice in our code, and in the other
place, in engine.py, the file is certainly read/write, so this check is
not needed. The extra complexity didn't seem to be justified for only
one use. If we end up needing this in more places, it can certainly be
refactored into the portable module later.
2. I didn't add a special test case because the t_pkg_install.py tests
that use [email protected] already test this case. The reason this problem wasn't
seen earlier on Windows is that the CLI tests are not run there (yet).
Thanks.
Tom
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
