On Sat 29 Aug 2009 at 02:44PM, Shawn Walker wrote:
> Dan Price wrote:
> >Please review my fix for:
> >
> >  11029 Implement Flyweight pattern and __slots__ to reduce fmri memory 
> >  usage
> >
> >Details in the bug report; the redux is that on my system, this saves
> >about 24MB of memory on install, image-update, list, etc.
> >
> >  http://cr.opensolaris.org/~dp/pkg-mem/
> 
> cr.opensolaris.org seems inaccessible.  Doh.
> 
> >I believe that the net result is that cache_fmri() is both much
> >more space efficient, and a bit faster.
> 
> Ooops; I've completely eliminated cache_fmri in my new catalog wad :D

Shawn,

Can you apply my patch to your wad and see if it helps with memory
footprint?  Just look at peak memory usage on pkg image-update -nv
before and after.

It's not worth the complexity it if it doesn't help with footprint.

n.b. it might be useful again in the future with the SAT solver.

        -dp

-- 
Daniel Price, Solaris Kernel Engineering    http://blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to