Hey Padraig.
With respect to the issue below, __main_application_quit ain't quitting;
it's getting hung up on the sys.exit(0).
Looking at some DTrace output, I *think* that the failure of
__main_application_quit to quit is allowing the transport engine to
continue running -- and with my connection to the outside world severed
(or the repo down as was the case this weekend), it just keeps
trying....
This solves it for me:
~~~~~~~~~~~~~~~~~
diff -r d3b0ddf1d1c2 src/packagemanager.py
--- a/src/packagemanager.py Fri Aug 28 14:36:19 2009 -0700
+++ b/src/packagemanager.py Mon Aug 31 18:25:48 2009 -0400
@@ -2676,7 +2676,7 @@
while gtk.events_pending():
gtk.main_iteration(False)
gtk.main_quit()
- sys.exit(0)
+ os._exit(0)
return True
def __check_if_something_was_changed(self):
~~~~~~~~~~~~~~~~~
Hope this is of some use. Take care.
--joanie
On Mon, 2009-08-31 at 13:53 -0400, Joanmarie Diggs wrote:
> Hey Padraig.
>
> This definitely helps things, but there seems to be a process lingering.
> To best appreciate it, keep your local network connection, but sever
> ties to the outside world. Compare:
>
> ~~~~~~~~~~~~~
> Before patch:
> ~~~~~~~~~~~~~
> $ pfexec ptime packagemanager
> /usr/bin/packagemanager:3248: GtkWarning: file gtktreeselection.c: line
> 354: assertion `selection->tree_view != NULL' failed
> model, itr = self.package_selection.get_selected()
>
> real 59.269348446
> user 25.108675577
> sys 1.776196814
> ptime: command terminated abnormally by SIGSEGV
>
> ~~~~~~~~~~~~~
> After patch:
> ~~~~~~~~~~~~~
> $ pfexec ptime packagemanager
> real 19.984064393
> user 19.432046979
> sys 1.182571846
>
> BUT having severed my outside connection (waiting a long time for the
> process to terminate on its own, and finally re-establishing my
> connection):
>
> $ pfexec ptime packagemanager
> real 21:29.597118893
> user 7.053811630
> sys 0.897445571
>
> (Note that I see the same behavior with the severed connection without
> your patch.)
>
> HTH. Take care.
> --joanie
>
> On Mon, 2009-08-31 at 11:26 +0100, Padraig O'Briain wrote:
> > The webrev, http://cr.opensolaris.org/~padraig/ips-11034-v1/, fixes
> > 11034 Packagemanager hangs if quit during catalog refresh
> >
> > The change ensures that PackageManager closes down tidily if the
> > application window is closed while catalogs are being refreshed.
> >
> > Padraig
> > _______________________________________________
> > pkg-discuss mailing list
> > [email protected]
> > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
>
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
