Shawn Walker wrote:
webrev:
http://cr.opensolaris.org/~swalker/pkg-cat-p2/
I haven't done a thorough review, but here are some issues that jumped
out at me:
1. The ImageInterface.__init__ method should not take an Image as an
argument. This has the effect of exposing the entire Image object to
the users of ImageInterface, and the original intent of introducing the
api module and ImageInterface was to hide the Image object. Eventually,
client.py should be written without referencing Image at all. Is this a
temporary change?
2. The version change in api.py indicates that this new code is
compatible with version 19, but with all of the exceptions that were
removed from api_errors.py, I don't see how this can be compatible.
3. I was surprised to see image.py importing pkg.server.catalog.
Shouldn't the client and server code be kept separate? If there is
common code, that should be refactored to the pkg module or in another
shared module.
Thanks.
Tom
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
