Shawn Walker wrote:
Brock Pytlik wrote:
New webrev here:
http://cr.opensolaris.org/~bpytlik/ips-10515-v2/
tests/cli/t_pkg_search.py:
line 83: JUST_UNKNOWN would be a bit more readable
Ok
lines 268, 280: extra newline
I'll fix those.
lines 307, 308: debug code? seems redundant to the lines below
Actually, no. I went back and looked at this. The problem with search is
that when it fails it often is hard to figure out exactly what was
different. This just gives another useful way to see what happened. It
will only appear when the test is going to fail, so I'd like to leave it in.
line 682: we can't assume that the test machine will have access to
pkg.opensolaris.org; as far as I know, our test suite so far has never
required that. Does this test require a connection to
pkg.opensolaris.org? If so, it needs to be changed :/
Actually, we've had such a test case around for a long time. See line 507.
Brock
Cheers,
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
