Ok looks good to me apart from this minor nit:
I would use the 'status_newupdate', set in self.update_available_icon,
for the updates and not the legend_newupdate which should be removed and
is giving a bit of an offset which we don't want:
333 + self.update_for_category_icon = \
334 +
self.get_icon_pixbuf_from_glade_dir("legend_newupdate")
JR
Padraig O'Briain wrote:
I have respun the webrev so that it applies to the gate
http://cr.opensolaris.org/~padraig/ips-8224-v8/
The only change I made other than fixing patching errors was to change
Package Source to Publisher in the details panel.
Padraig
On 09/03/09 12:00, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-8224-v7/, fixes
8224 PM Format poor on multiline Summary in Description and some locales
This webrev changes the details panel to what is proposed by xdesign
team.
It also removes unused code related to package icon.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
