Danek Duvall wrote:
Brock Pytlik wrote:
Danek Duvall wrote:
Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-11104-v1/
Is there a chance that rebuild_index_from_scratch() could raise an
exception? If so, then presumably the clears should be un-done. Or move
them after the index rebuild.
I don't understand this. If rebuild_index from scratch raises an
error, then the indexes will not be written to disk, so undoing the
clears won't make any difference.
In a long-running process, where we pass through this point multiple times,
will the sets be re-built each time based on what's on disk?
They'll be reread from disk on each pass through generic_update_index.
Does that allay your concerns?
Brock
Should the test at the top be on self._data_fast_remove as well?
If you mean the test in indexer to decide whether to do the rebuild
from scratch, then no, it shouldn't.
Okay.
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
