Shawn Walker wrote:
Danek Duvall wrote:
- Is signing really that much of a problem, performance-wise? Is it just the setting of sort_keys in the JSON dumper? We're eventually going to do be doing it on all of our own catalogs, so optimizing for when it's
    not there doesn't seem especially useful in the long run.

There seemed little point to signing the image catalogs or transformed v0 catalogs.

So, to quanitfy this, it saves between 2-5 seconds on my x86 system to not sign the files and about the same on SPARC (cuphead.sfbay).

This isn't surprising as, internally, simplejson has C python extensions that are only used when sort_keys=False. To ensure a consistent signature, I have to use sort_keys=True.

If you think this is relatively small gain for the possible benefit of being able to verify whether the *image* catalog files have been corrupted or changed since they were last written, I'm willing to undo all of the sign=... changes since it's not a huge win.

Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to