anyone?

On 11-Sep-09, at 3:11 PM, John Sonnenschein wrote:

[email protected] wrote:
On Thu, Sep 10, 2009 at 01:17:07PM -0700, John Sonnenschein wrote:

http://cr.opensolaris.org/~error404/11273/


After I updated 11273 to suggest using Popen, Danek pointed out that it would be better to add something to the testsuite that allows us to log
output, and print it only when a command fails.

In order to do that, you probably want to use Popen with a different set of arguments. It would work better if you set stdout to PIPE stderr to
stdin.  The testutils module already has a bunch of commands that use
Popen in a similar fashion; there are lots of examples to choose from.

I would take a look at src/test/cli/testutils.py to see if you can come up with a generic method for CliTestCase that allows the caller to run a
command. If the command fails, then print the output.

Thanks,

-j


http://cr.opensolaris.org/~error404/11273-2 look good?


-JohnS


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to