Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-11350-v1/, fixes
11350 update-refresh.sh fails to find '_' (gettext)
There is no reason for the messages referrexd to in the bnug to be
translated as they are output only in debug mode. The fix is to not
attempt to translate the messages.
This isn't quite right as anywhere you print exceptions can trigger this
same issue. Remember that almost all of the api exceptions use '_()'
internally.
So, while this may solve this particular case, there seems little point
as other cases will fail. (See line 76, line 159). Yes, some of those
failures will only happen in debug mode, but it will just make things
harder to debug.
You really need to import gettext, do a gettext.install, etc. just like
client.py does.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
