On Tue, Sep 15, 2009 at 03:02:27PM -0600, Jerry Jelinek wrote:
> Edward Pilatowicz wrote:
>> hey all,
>>
>> i need a review for the following webrev:
>>
>> http://cr.opensolaris.org/~edp/pkg-verify/
>>
>> 8567 ipkg zones verify callback should abort if it sees inherit-pkg-dir
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=8567
>>
>> 10410 exclusive stack zones can't find a default router
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=10410
>>
>> i'm not really sure if i've done the distro-import update correctly.
>>
>> the trusted brand has a config.xml file which is basically a copy of the
>> ipkg brand config.xml file. but it lives directly in the
>> distro-importer, so to update it i made a new copy of it (which seems
>> like what we do with everything related to the distro-importer).
>> assuming that this is the correct thing todo, i'm wondering if i also
>> need to create a SUNWfixes.prototype for 124 and add a copy of the
>> config.xml entry found in:
>>
>> src/util/distro-import/111a/SUNWfixes.prototype
>>
>> if this isn't the right approach, then perhaps i should just update the
>> original config.xml file?
>>
>> src/util/distro-import/111a/config.xml
>
> Ed,
>
> I reviewed the zone-specific files (all but
> src/util/distro-import/124/config.xml) and they look good
> to me. I just had a couple small nits on the src/brand/support.c
> file which you can take or leave.
>
> I know we've done this elsewhere but I changed this for the
> s10 brand support code. The err() function is going to
> print a msg which looks like:
>
> support: brand does not support inherit-pkg-dirs
>
> The "support:" prefix doesn't seem to improve the error
> msg and I dropped this for the s10 brand. You might change
> the error msg wording to include the brand name. For example,
> "Error: the ipkg brand does not support inherit-pkg-dirs".
>
well, since err() can be used to emit other error messages, i'd
like to leave the "support" part in there. but i've updated it
to say "support ipkg brand error: XXX". so now we'll have the
following possible error messages:
support ipkg brand error: invalid usage
support ipkg brand error: internal libzonecfg.so.1 error
support ipkg brand error: zonecfg provided an invalid XML file
support ipkg brand error: brand does not support inherit-pkg-dirs
> Also, the comment at line 114 is incorrect and should probably
> just be removed.
>
done.
the webrev is updated.
thanks for looking at this.
ed
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
