On Mon, Sep 21, 2009 at 01:46:41PM -0700, Brock Pytlik wrote: > Can I get one more person to look at this? I'd like to get this in > before I put my file layout stuff out for review because it depends on > these changes. > > Thanks, > Brock > > Brock Pytlik wrote: >> Webrev: >> http://cr.opensolaris.org/~bpytlik/ips-11400-v1/
Most of this looks fine. I'm curious if the assertions in image.py on lines 170-173 should be assertions, though. Would it be better to raise an exception with a more detailed error message, or is this just a sanity check? My concern is that callers of image.__init__ will get an assertion failure instead of a ValueError, or some kind of custom exception, that might be more informative. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
