Hello,
There was no bug against this, so now I am following our procedure.
I will need the acceptance to integrate this.
best
Michal
-------- Original Message --------
Subject: Re: [pkg-discuss] SUNWldtp
Date: Wed, 30 Sep 2009 22:22:39 +0100
From: Michal Pryc <[email protected]>
To: Danek Duvall <[email protected]>
CC: [email protected], pkg discuss <[email protected]>,
Qinghua Cheng <[email protected]>
References: <[email protected]> <[email protected]>
<[email protected]>
Danek, Jim,
New webrev:
http://cr.opensolaris.org/~migi/integrate_ldtp_v6/
- I have removed part for building and left only make install as you
have suggested
- make_done is gone
- Removed return value of run_cmd() as suggested
- Added license disclaimers for both GPL and LGPL
- src/pkgdefs/SUNWldtp/prototype - added CDDL header
best
Michal
http://cr.opensolaris.org/~migi/integrate_ldtp_v5/
This seems okay to me, though the return value of run_cmd() is always 0, so
there's no need to return anything, or test the return value in its
callers. Also, is the "make_done" file really necessary? Can't you just
run "make install" instead of the separate "make" and "make install" steps?
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
