Michal Pryc wrote:
Shawn Walker wrote:
Greetings,

The following webrev contains fixes for the following issues:

  11763 make install noise / packages failure for ldtp if PYTHONPATH set
  11765 src/brand/support should be added to .hgignore

webrev:
http://cr.opensolaris.org/~swalker/pkg-11763/


Shawn,
Thanks a lot for finding the problem and solution. The webrev looks fine for me.

I was not able to reproduce this problem on my box, as PYTHONPATH is set.

I'm assuming you mean *not* set.

My only concern was about overriding user's PYTHONPATH, but the lines:

454  454                          saveenv = os.environ.copy()

and


458  458                          os.environ = saveenv

will actually prevent from that.

Right, and in this case, I'm not changing the active environment, I'm only setting PYTHONPATH for the single command being execute (configure).

Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to