Tom,
Tom Mueller (plain-text) wrote:
I justed refreshed from the gate and did a "python setup.py install",
and I see that ldtp is being downloaded and installed automatically.
Also, there is a build failure when it tries to build ldtp.c - "cannot
find include file: <X11/Xlib.h>".
I did send an informationr Today:
http://mail.opensolaris.org/pipermail/pkg-discuss/2009-October/017543.html
Also there is a bug logged to track it:
http://defect.opensolaris.org/bz/show_bug.cgi?id=11757
And webrev prepared to fix it. Probably this webrev will need some
tweaking to move things from folder to 124 to 125 as said earlier Today.
http://cr.opensolaris.org/~migi/11757_v2/
Are there new requirements for the build now? And why is ldtp being
installed as part of the portable part of the build? Should this be
done in the Makefile since ldtp isn't available for all platforms?
Sorry for missing a code review.
No worries, we are all busy, so it's easy to miss something.
Please refer to the e-mail:
http://mail.opensolaris.org/pipermail/pkg-discuss/2009-August/015984.html
There was a lot of discussion where it should live. I have prepared
webrev to integrate this in the Makefile and then the decision was made
to integrate this through the setup.py as Danek suggested.
I am pretty sure LDTP will run under linux as well, if you will require
this I can test it, but the whole purpose of integrating LDTP was to
perform automated tests on the IPS GUI and IPS GUI was actually never
run on GNU/Linux platform.
The setup.py does check if the build is run on Solaris, otherwise
building LDTP will be omitted (line 451):
http://cr.opensolaris.org/~migi/integrate_ldtp_v6/src/setup.py.html
--
best
Michal Pryc
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
