Danek,
It's my stupidity - I moved line from list 195 to line 206, but cuting from 195 made line 206 de facto 207. Of course you are right it will not work as gui_suite is used before it's defined.

Another thing is the failure of the tests. The way accessibility is tested in the bug description:

$  gconftool-2 --get /desktop/gnome/interface/accessibility

Is not valid as the user needs to log out and log in to the GNOME session, so setting/unsetting accessibility gconf key doesn't make it happen. That is why we are finding this by running very simple gtk application and checking if the widget have some accessible widgets. This way we are sure that a11y is on:

http://cr.opensolaris.org/~migi/automated_tests_10_aug/src/tests/gui/testutils.py.html

Probably somewhere with "ssh -X" this test returns incorrect state, but I will need to confirm this and spin another webrev.

best
Michal Pryc

Danek Duvall wrote:
Michal Pryc wrote:

http://cr.opensolaris.org/~migi/11773_fix/

I'm curious how you tested that -- gui_suite is used before it's defined.

Also, why is it that Brock's machine, which has accessibility disabled,
didn't just run into the elif clause that disabled the gui tests because
accessibility wasn't enabled?

Danek

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to